sor/eor triggers use numeric bounds for the unknown fields in validity #2544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this ensures that: - SOR trigger uses validity end which is understood by the framework as unknown - EOR trigger uses validity start which is understood by the framework as unknown For better or worse, we use numerical limits of validity_time_t as unknown/invalid validity timestamps. We could consider using optionals instead, but before we do, this is the easiest fix.
knopers8
force-pushed
the
sor-eor-validity
branch
from
7e2df27 to
dd2fc23
Compare
Barthelemy
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this ensures that:
For better or worse, we use numerical limits of validity_time_t as unknown/invalid validity timestamps. We could consider using optionals instead, but before we do, this is the easiest fix.